There's a stray linebreak on the end of each URL, so probably a stupid carriage return (\r), and thus I'd guess you're only splitting on newline (\n).

 

Either include an optional CR in your split (i.e. \r?\n if it's a regex), or better still set your text file (and any editors you have) to only use single-character newlines, so it doesn't even become an issue.

I'm about to leave work

Here's the full code if it is of interest

<?php
$dropb = 'http://dl.dropbox.com/u/blah/';
$user_file = @fopen("gallery1.txt", "r");
if ($user_file)
{
	while (!feof($user_file)) 
	{
    	$lines[] = fgets($user_file, 4096);
	}
   	fclose($user_file);
   	foreach($lines as $line => $data)
   	{
   	   	echo '<a href="'. $dropb .''. $data .'" class="fancybox"><img src="'. $dropb .''. $data .'" width="190px" /></a>';
   	}
}
?>

I'll look into fixing it when I get home.

I thought you were making a dropbox like deal using PHP. I was going to tell you how much I look up to you and how you've always been my favorite. But since you're not doing that I can't say those things to you!

Ha. That's still on Peter's to do list.

Hmmm, I'm guessing fgets includes the newline with the string, in which case you can either change that single line to this:

$lines[] = trim(fgets($user_file, 4096);)

Or replace the whole while loop with this:

$lines = preg_split( '\r?\n' , trim(fread($user_file , filesize($user_file))) );

Dan Herman already did that about ten years about. :P

Show me!

http://sourceforge.net/projects/vault/

It doesn't look very dropbox like to me.

I'll give that a go. Thanks.

Uh, you're looking at SourceForge aren't you? :S

yes.

Wow, I'd forgotten that :')

Works a treat. Thanks PB. Don't believe what the others say, you are helpful!

Now there's a blast from the past. Someone on here told me it was a pointless endeavour because anyone who wanted to put files on the Internet would have hosting :-(

 

I ought to be rich...

:(

 

I blame PB.

Dropbox is bloody slow, much slower than the free hosting I found.

I may be talking completely out of my hat here:

 

Could it be integrated into Beehive in any way?

 

At the moment when I go to attachments I can see everything i've uploaded. Maybe using this people can browse each others attachments (if given permission).
For example, Fozza attaches torrent files for teh podcast. While attaching the file is put in his storage, which could even be on another server that uses Teh for authentication in some way. As long as they're in his storage you don't even have to look for the thread they were originally posted in. You just go to his profile and look in his storage.

 

And he can select who on the forum can see his files, creating groups from the user list. Mods could then share files of world domination without the common people having access.

 

I don't know if you can do this with dropbox but having the capability to do it on your own server instead of trusting someone else might come in useful for some people - even if it isn't useful for us it helps distinguish Beehive from other Forum software.

 

</possibly useless thought>

Whoa, I dunno :-D

Is it possible clear any memory of previous PHP code?

 

I want to pull from a few text files but it seems to have the previous one in the memory.