I'll look into those.

 

I have now sorted the problem with a text file but a better solution would be nice.

The latter is just a PHP wrapper around the former, though it wasn't clear if it implements all the functionality yet, and doing REST with PHP probably isn't hard and might even be a useful skill to have, so I probably wouldn't bother with the wrapper version.

Why does this output the HTML over three lines? Or maybe it's not splitting it at all?

echo '<a href="'.$drop.$data.'" class="fancybox"><img src="'.$drop.$data.'" width="190px" /></a>';

I want this....

<a href="http://dl.dropbox.com/u/blah/photo1.JPG" class="fancybox"><img src="http://dl.dropbox.com/u/blah/photo1.JPG" width="190px" /></a>
<a href="http://dl.dropbox.com/u/blah/photo2.JPG" class="fancybox"><img src="http://dl.dropbox.com/u/blah/photo2.JPG" width="190px" /></a>
<a href="http://dl.dropbox.com/u/blah/photo3.JPG" class="fancybox"><img src="http://dl.dropbox.com/u/blah/photo3.JPG" width="190px" /></a>
<a href="http://dl.dropbox.com/u/blah/photo4.JPG" class="fancybox"><img src="http://dl.dropbox.com/u/blah/photo4.JPG" width="190px" /></a>
<a href="http://dl.dropbox.com/u/blah/photo5.JPG" class="fancybox"><img src="http://dl.dropbox.com/u/blah/photo5.JPG" width="190px" /></a>

But get this....

<a href="http://dl.dropbox.com/u/blah/photo1.JPG
" class="fancybox"><img src="http://dl.dropbox.com/u/blah/photo1.JPG
" width="190px" /></a><a href="http://dl.dropbox.com/u/blah/photo2.JPG
" class="fancybox"><img src="http://dl.dropbox.com/u/blah/photo2.JPG
" width="190px" /></a><a href="http://dl.dropbox.com/u/blah/photo3.JPG
" class="fancybox"><img src="http://dl.dropbox.com/u/blah/photo3.JPG
" width="190px" /></a><a href="http://dl.dropbox.com/u/blah/photo4.JPG
" class="fancybox"><img src="http://dl.dropbox.com/u/blah/photo4.JPG
" width="190px" /></a><a href="http://dl.dropbox.com/u/blah/photo5.JPG" class="fancybox"><img src="http://dl.dropbox.com/u/blah/photo5.JPG" width="190px" /></a>

There's a stray linebreak on the end of each URL, so probably a stupid carriage return (\r), and thus I'd guess you're only splitting on newline (\n).

 

Either include an optional CR in your split (i.e. \r?\n if it's a regex), or better still set your text file (and any editors you have) to only use single-character newlines, so it doesn't even become an issue.

I'm about to leave work

Here's the full code if it is of interest

<?php
$dropb = 'http://dl.dropbox.com/u/blah/';
$user_file = @fopen("gallery1.txt", "r");
if ($user_file)
{
	while (!feof($user_file)) 
	{
    	$lines[] = fgets($user_file, 4096);
	}
   	fclose($user_file);
   	foreach($lines as $line => $data)
   	{
   	   	echo '<a href="'. $dropb .''. $data .'" class="fancybox"><img src="'. $dropb .''. $data .'" width="190px" /></a>';
   	}
}
?>

I'll look into fixing it when I get home.

I thought you were making a dropbox like deal using PHP. I was going to tell you how much I look up to you and how you've always been my favorite. But since you're not doing that I can't say those things to you!

Ha. That's still on Peter's to do list.

Hmmm, I'm guessing fgets includes the newline with the string, in which case you can either change that single line to this:

$lines[] = trim(fgets($user_file, 4096);)

Or replace the whole while loop with this:

$lines = preg_split( '\r?\n' , trim(fread($user_file , filesize($user_file))) );

Dan Herman already did that about ten years about. :P

Show me!

http://sourceforge.net/projects/vault/

It doesn't look very dropbox like to me.

I'll give that a go. Thanks.

Uh, you're looking at SourceForge aren't you? :S

yes.

Wow, I'd forgotten that :')

Works a treat. Thanks PB. Don't believe what the others say, you are helpful!

Now there's a blast from the past. Someone on here told me it was a pointless endeavour because anyone who wanted to put files on the Internet would have hosting :-(

 

I ought to be rich...

:(

 

I blame PB.

Dropbox is bloody slow, much slower than the free hosting I found.