Lightbox2

From: af (CAER)31 May 2011 09:56
To: ANT_THOMAS 39 of 91
Ah, no, it won't make images bigger, although I can make it do that if you want. Why do you want to do that? They'll look all blurry/pixelly :S

Actually I'd best check if the max size thing actually works :$

edit: works here, although I did notice that I missed a ; off the end of the example config, which might cause some browsers to reject it. It should look something like this:
JavaScript code:
QuickSlideConfig = {
  loading_spinner_url = "loading-spinner.gif",
  max_width: 800,
  max_height: 600,
  auto_fit: true };
And to clarify, the size of the popup is determined by the the size of the image first, then any max_width/size settings are applied, then if the auto_fit option is set the image is scaled to fit the window, if necessary.
EDITED: 31 May 2011 10:03 by CAER
From: ANT_THOMAS31 May 2011 10:14
To: af (CAER) 40 of 91
I want to make a large image smaller.

So if I have this at the top of my page...
JavaScript code:
QuickSlideConfig = {
  loading_spinner_url = "loading-spinner.gif",
  max_width: 320,
  max_height: 240,
  auto_fit: true };


and this at the bottom
HTML code:
<script src="quickslide.js"></script>


With this in the middle
HTML code:
<a rel="quickslide" href="/folder/image.jpg"><img src="/folder/image.jpg" alt="" width="300" /></a>


Where the "image.jpg" is the same file/image for both and is 5MP.

Should the 5MP image show as ~320x240 in the popup?
From: af (CAER)31 May 2011 10:15
To: ANT_THOMAS 41 of 91
It should, yes.
From: ANT_THOMAS31 May 2011 10:18
To: af (CAER) 42 of 91

It doesn't :(

 

Chrome 11.0.696.71 and FF 4.0.1

 

The popup seems to be working but the image is 100% size and not scaled at all.
I'll see if I can get you any more details.

From: af (CAER)31 May 2011 10:21
To: ANT_THOMAS 43 of 91
By 100% size, you mean it's displaying at around 2592 × 1944, i.e.a gigantic popup covering the entire browser window?

I wonder if it's related to the use of full-size images as thumbnails. I shall investigate.

edit: you are putting the config stuff inside <script> tags, aren't you?
EDITED: 31 May 2011 10:23 by CAER
From: ANT_THOMAS31 May 2011 10:30
To: af (CAER) 44 of 91

Yes, showing as gigantic popup covering entire window, and yes it's inside <script> tags. I should've added the tags on here.

 

The content was being pulled from an MySQL db by PHP but I've just tried it with one of the same image files in a plain HTML file and it still happens.

From: ANT_THOMAS31 May 2011 10:32
To: af (CAER) 45 of 91
From: af (CAER)31 May 2011 10:39
To: ANT_THOMAS 46 of 91
Oh, I see the problem. My fault :$

The browser is tripping over the config, because in my example I have

loading_spinner_url = "loading-spinner.gif",

when it should be:

loading_spinner_url: "loading-spinner.gif",

(a : not an = sign)

I've also uploaded a newer version of the code which makes the scaling a bit simpler.
From: ANT_THOMAS31 May 2011 10:40
To: af (CAER) 47 of 91
Yay, that works. I shall also download the new version.
From: ANT_THOMAS31 May 2011 10:53
To: af (CAER) 48 of 91
You might want to tell people to add the stylesheet link to the top of the page too. I was wondering why my images didn't have pretty borders :$
From: af (CAER)31 May 2011 11:06
To: ANT_THOMAS 49 of 91
Heh, that's included in the .zip download :D

Also I just updated it again to remove the calls to console.log (which would make IE8 fall over), and fixed some positioning issues when using auto-scaling.
From: ANT_THOMAS31 May 2011 11:14
To: af (CAER) 50 of 91
Now I need to get "quickslide" into the Relationship Page to Target list in TinyMCE.
From: ANT_THOMAS31 May 2011 11:43
To: af (CAER) 51 of 91

Found a problem. I have a long page with 3 images/thumbs on it at different points down the page. First image/thumb is near the top, have to scroll to get to the other 2.

 

When I click the top one the popup appears half way down the page and I need to scroll down to see it.

 

Are you having the popup appear at the middle of the page height/vertical wise, rather than at the middle of the window?

From: af (CAER)31 May 2011 11:45
To: ANT_THOMAS 52 of 91
It should appear in the middle of the page, plus scrolling.

I wonder if the issue is related to the size of the images. I suspect it might not be using the defined max sizes when positioning the images. Lemme take a look.
From: ANT_THOMAS31 May 2011 11:58
To: af (CAER) 53 of 91
If you've not seen the problem I've replicated it on the test file I linked to above.
From: af (CAER)31 May 2011 11:59
To: ANT_THOMAS 54 of 91
Ok I think I found the problem. Have uploaded a (hopefully) fixed version now.
From: ANT_THOMAS31 May 2011 12:05
To: af (CAER) 55 of 91
Still there on my test page after updating quickslide.js
From: af (CAER)31 May 2011 13:21
To: ANT_THOMAS 56 of 91
Hm, try adding this to your CSS:
CSS code:
body { overflow-y: scroll; }
From: ANT_THOMAS31 May 2011 13:31
To: af (CAER) 57 of 91

Nope :(

 

I've updated the test and you'll see if you click the bottom one it extends the page below the normal length of the page.

From: af (CAER)31 May 2011 16:29
To: ANT_THOMAS 58 of 91
Ok, I've uploaded a test version that will output some information to the JavaScript console. In Chrome you can see this by pressing Ctrl+Shift+j (I think). Just click an image and tell me what it reports. It will list image height, scroll pos and window height. Do any of the numbers look wrong?